Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #83822: set config.BindAddress to IPv4 address "127.0.0.1" if not #84391

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Automated cherry pick of #83822: set config.BindAddress to IPv4 address "127.0.0.1" if not #84391

merged 1 commit into from
Nov 26, 2019

Conversation

zouyee
Copy link
Member

@zouyee zouyee commented Oct 25, 2019 •
edited

Cherry pick of #83822 on release-1.16.

#83822: set config.BindAddress to IPv4 address "127.0.0.1" if not

For details on the cherry pick process, see the cherry pick requests page.

Change kube-proxy's default node IP back to 127.0.0.1, if this is incorrect, please use --bind-address to set the correct address

set config.BindAddress to IPv4 address "127.0.0.1" if not specified
cdba9be 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 25, 2019
@zouyee
Copy link
Member Author

zouyee commented Oct 25, 2019

/cc @andrewsykim
/assign @thockin

@k8s-ci-robot k8s-ci-robot added area/ipvs sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 25, 2019
@andrewsykim
Copy link
Member

andrewsykim commented Oct 29, 2019 •
edited

/lgtm

Release note should also say "if incorrect, use --bind-address to set the correct address"

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@andrewsykim
Copy link
Member

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 29, 2019
@zouyee
Copy link
Member Author

zouyee commented Oct 30, 2019

/assign @MrHohn

@andrewsykim
Copy link
Member

@zouyee sorry if I wasn't clear earlier. Just "if incorrect, use --bind-address to set the correct address" is not clear anymore. The release notes should be something like:

Change kube-proxy's default node IP back to 127.0.0.1, if this is incorrect, use --bind-address to set the correct address

@thockin
Copy link
Member

thockin commented Nov 15, 2019

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019
@andrewsykim
Copy link
Member

cc @kubernetes/patch-release-team

@idealhack idealhack added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5c651b7 into kubernetes:release-1.16 Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cmluciano cmluciano Awaiting requested review from cmluciano

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@thockin thockin

@MrHohn MrHohn

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zouyee @andrewsykim @thockin @k8s-ci-robot @idealhack @MrHohn